https://bugzilla.redhat.com/show_bug.cgi?id=1761338

Artem <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Artem <[email protected]> ---
1. Linter still warning about unowned dirs. We probably need to move this
Requires from main package to 'common'?

%package        common
Summary:        Common files for Double Commander

Requires:       hicolor-icon-theme
Requires:       polkit%{?_isa}


2. Source0:       
http://sourceforge.net/projects/%{name}/files/Double%20Commander%20Source/%{name}-%{version}-src.tar.gz
   ->
   Source0:       
https://sourceforge.net/projects/%{name}/files/Double%20Commander%20Source/%{name}-%{version}-src.tar.gz

Probably better switch to https.


But overall LGTM. This minor issues could be fixed during import.

---


[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/polkit-1,
     /usr/lib/.build-id/6a, /usr/share/polkit-1/actions,
     /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable/apps,
     /usr/lib/.build-id/12, /usr/share/icons/hicolor/scalable

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to