On 09/04/2026 15:16, Eelco Chaudron wrote:
External email: Use caution opening links or attachments
On 1 Apr 2026, at 11:13, Eli Britstein wrote:
Introduce a new netdev type - netdev-doca.
Hi Eli/Gaetan,
Not sure if you’ve noticed, but this series has failing tests due to a
UBSan issue in patch 1. Maybe you can take a quick look and fix this so
that all unit tests pass.
I would suggest setting up a GitHub Action in your local repo so these
tests run before submitting a series. That way, you can be sure it passes
at least the basic checks.
I’ll start reviewing the series, but I’ll be on PTO at the end of next
week for about a week, so a full review may take some time. I’ll try to
send comments on individual patches so you can continue working on what
has been reviewed so far.
Cheers,
Eelco
Example error:
../../lib/ovs-rcu.c:292:9: runtime error: call to function rule_destroy_cb
through pointer to incorrect function type 'void (*)(void *)'
/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/../../lib/ovs-router.c:1244:
note: rule_destroy_cb defined here
#0 0x560e4675ce49 in ovsrcu_run_cbset
/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/../../lib/ovs-rcu.c:292:9
#1 0x560e4675bef1 in ovsrcu_call_postponed
/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/../../lib/ovs-rcu.c:370:9
#2 0x560e4687e368 in time_poll
/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/../../lib/timeval.c:325:17
#3 0x560e467f76d4 in poll_block
/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/../../lib/poll-loop.c:364:14
#4 0x560e4613c401 in main
/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/../../vswitchd/ovs-vswitchd.c:149:9
#5 0x7efe9d42a1c9 (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId:
8e9fd827446c24067541ac5390e6f527fb5947bb)
#6 0x7efe9d42a28a in __libc_start_main
(/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId:
8e9fd827446c24067541ac5390e6f527fb5947bb)
#7 0x560e46027fa4 in _start
(/home/runner/work/ovs/ovs/openvswitch-3.7.90/_build/sub/vswitchd/ovs-vswitchd+0x74efa4)
(BuildId: a540f0f744c789e977aecf68f1c17a835856d3f8)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../../lib/ovs-rcu.c:292:9
Sure, I'll take that into consideration.
So far, I found some issues myself that will be fixed in v4:
- refmap still may fail in the scenario you described
- there is no destroy of the mempool
- demote some error messages to WARN if adding a non-existent port or
invalid port
- some documentation fixes and improvements
Also, currently there is no support to build deb/rpm with doca support.
I'm working on that, so it will probably affect the flags stuff around
acinclude.m4.
Enjoy your PTO.
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
