Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1558?usp=email )
Change subject: dns: Change arguments to setenv_dns_option to avoid sign-compare warning ...................................................................... Patch Set 3: (1 comment) File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/1558/comment/afed0dee_70196530?usp=email : PS2, Line 487: if (!j) > technically this is fine, but it takes me as a reader few more seconds to > understand what this check […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1558?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b1625dcb7e6fb5 Gerrit-Change-Number: 1558 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2026 13:26:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
