Attention is currently required from: its_Giaan, plaisthos. ordex has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1555?usp=email )
Change subject: socket: restore per-connection lport override over global default ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/1555/comment/29141286_321bf2c0?usp=email : PS1, Line 1350: const char *port = (o->mode == MODE_POINT_TO_POINT && o->ce.local_port_defined) similarly to what we do with o->ce.proto, can we have an if just below the variables declaration, rather than having this longer/complex expression in here? we could just have: if (o->mode == MODE_POINT_TO_POINT && o->ce.local_port_defined) { port = o->ce.local_port } and keep the variable declaration/initialization as it was before. Maybe also add a comment of top of that if saying something like "if --lport is specified in a client connection block we give it higher priority" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1555?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7cf5d5ef7e2531f397ad97baf4663e3763072f6b Gerrit-Change-Number: 1555 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 13:42:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
