> On Oct. 17, 2011, 3:38 a.m., Jonathan Yap wrote: > > indra/newview/skins/default/xui/en/panel_landmarks.xml, line 77 > > <http://codereview.secondlife.com/r/499/diff/1/?file=7268#file7268line77> > > > > Am I missing the place in the code where there is a corresponding > > setVisible call since the default now seems to be not visible?
setVisible is done somewhere down the inheritcance tree. It works without an explicit call, so I did not want to stick one in. - Lance ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/499/#review1056 ----------------------------------------------------------- On Oct. 17, 2011, 3:23 a.m., Lance Corrimal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/499/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2011, 3:23 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > When the user hides the library by setting the debug setting > "NoInventoryLibrary" to TRUE, the Library accordion in the landmark panel > stays and duplicates the "My Inventory" accordion. This patch fixes that. > > > This addresses bug VWR-27184. > http://jira.secondlife.com/browse/VWR-27184 > > > Diffs > ----- > > indra/newview/llpanellandmarks.cpp 871963a3c7b9 > indra/newview/skins/default/xui/en/panel_landmarks.xml 871963a3c7b9 > > Diff: http://codereview.secondlife.com/r/499/diff > > > Testing > ------- > > using this patch in Dolphin Viewer 3 since 3.0.11 without problems. > > > Thanks, > > Lance > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
