----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/444/#review985 -----------------------------------------------------------
indra/newview/llappviewer.cpp <http://codereview.secondlife.com/r/444/#comment1003> Would be clearer as: if (!mSignal.empty()) { mSignal(); mSignal.disconnect_all_slots(); } - Oz On Aug. 19, 2011, 10:06 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/444/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2011, 10:06 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > In busy mode offered inventory items are now moved to trash. > > There were two bugs: > > 1. When auto-discarding inventory offers we looked up missing Busy button > (i.e. a button having index=3) in the inventory offer notification dialog > template. Failure to find the button resulted in ignoring inventory offers. > > Fixed that by "auto-clicking" the existing Discard button. > > 2. It turned out impossible to properly remove an inventory item > from within LLDiscardAgentOffer::done(), because that would lead to > nested LLInventoryModel::notifyObservers() calls. > > Fixed that by deferring removal until the next LLAppViewer::idle() iteration. > > > This addresses bug STORM-1543. > http://jira.secondlife.com/browse/STORM-1543 > > > Diffs > ----- > > indra/newview/llappviewer.h 478aabd2813b > indra/newview/llappviewer.cpp 478aabd2813b > indra/newview/llviewermessage.cpp 478aabd2813b > > Diff: http://codereview.secondlife.com/r/444/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
