----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/443/#review983 -----------------------------------------------------------
Ship it! good catch! - Richard On Aug. 19, 2011, 3:55 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/443/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2011, 3:55 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > Bug: > Settings for ignorable dialogs were reset during deferred auto-upgrade. > > Reason: > In case of deferred upgrade (i.e. when you select "Later...") the defaults > for notifications settings are not loaded, > so when the viewer exits after launching the updater, it incorrectly re-saves > notifications settings. > > Fix: > Initialize settings earlier, so that viewer picks them up in update mode. > > > This addresses bug STORM-1268. > http://jira.secondlife.com/browse/STORM-1268 > > > Diffs > ----- > > indra/newview/llappviewer.cpp 478aabd2813b > > Diff: http://codereview.secondlife.com/r/443/diff > > > Testing > ------- > > See acceptance criteria in the JIRA ticket. > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
