----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/ -----------------------------------------------------------
(Updated June 20, 2011, 6:55 a.m.) Review request for Viewer. Changes ------- Changed sort functor return type to bool. Although it was not strictly necessary, because according to http://www.sgi.com/tech/stl/BinaryPredicate.html "The result type must be convertible to bool", and int is. Summary ------- Apparently, a nearby chat toast got somehow destroyed while still remaining in the list of active toasts. Attempt to sort active toasts in showToastsBottom() then triggered the crash. I don't know how to reproduce the crash, i.e. force destroying a toast in a way that its onClose() method (which would remove references to the toast) isn't called. So we'll just remove references to the toast whenever it's destroyed. This addresses bug STORM-1352. http://jira.secondlife.com/browse/STORM-1352 Diffs (updated) ----- indra/newview/llnearbychathandler.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/341/diff Testing ------- Thanks, Vadim
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
