-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/256/
-----------------------------------------------------------
Review request for Viewer.
Summary
-------
This patch adds code to j2c to:
- compress images with the use of precincts and blocks
- use different ordering (RPCL) and markers in the codestream
- allow loading of images with region constraint
All this code can be exercised with a new set of arguments using
llimage_libtest. For the moment, the viewer is still saving images with the old
precinct and ordering.
Things done in this patch:
- Add arguments to llimage_libtest:
-- on j2c output : --precincts, --blocks
-- on j2c input : --region, --discard_level
- Add InitEncode() and InitDecode() methods to llimagej2c (and derived classes)
to implement new input and output parameters
- Fix perf analyzing report output in llimage_libtest (was broken)
- General llkdu code clean up: fixed all tab/white space issues, suppress code
that was unused, enforced coding conventions, use proper Kakadu method to get
its version number
This addresses bug STORM-746.
http://jira.secondlife.com/browse/STORM-746
Diffs
-----
indra/integration_tests/llimage_libtest/llimage_libtest.cpp d30636c2a83a
indra/llimage/llimagej2c.h d30636c2a83a
indra/llimage/llimagej2c.cpp d30636c2a83a
indra/llimagej2coj/llimagej2coj.h d30636c2a83a
indra/llimagej2coj/llimagej2coj.cpp d30636c2a83a
indra/llkdu/llimagej2ckdu.h d30636c2a83a
indra/llkdu/llimagej2ckdu.cpp d30636c2a83a
indra/llkdu/llkdumem.h d30636c2a83a
indra/llkdu/llkdumem.cpp d30636c2a83a
Diff: http://codereview.secondlife.com/r/256/diff
Testing
-------
Tested only on Mac. All the precincts code can be exercised through
llimage_libtest (see ./llimage_libtest --help for details on the new arguments)
None of the precincts/blocks creation is used in the viewer though, since
viewer code is modified, it would be good to test texture downloading,
uploading, j2c creation (snapshots and uploads) and all kind of texture loading
(sculpties, with and without alphas, small textures, big ones, etc...)
Thanks,
Merov
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
