> On Jan. 25, 2011, 3:28 a.m., Jonathan Yap wrote: > > 1) You should fill in the Bugs field with a Jira number. > > > > 2) Since VS2005 used the 80 code and VS2008 used 90, should you be using > > LL_MSVC100?
1. I had thought about jira but, it wasn't a bug of the current code. 2. vc80, vc90, and vc100 are passed to cmake from develop.py but, cmake output is MSVC80, MSVC90, AND MSVC10. So, either way is not consistent. The cmake output is used more frequently in code than the one time call in develop,py. - Nicky ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/121/#review249 ----------------------------------------------------------- On Jan. 25, 2011, 2:41 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/121/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2011, 2:41 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Need additional eyes on this. My first RB. > > > This addresses bug LL_MSVC10. > http://jira.secondlife.com/browse/LL_MSVC10 > > > Diffs > ----- > > indra/llcommon/llpreprocessor.h 26c09ad4293e > > Diff: http://codereview.secondlife.com/r/121/diff > > > Testing > ------- > > Complied with VS2010. Used with another patch around a microsoft bug. Have > not used with VS 2005 > > > Thanks, > > Nicky > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
