----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/56/#review64 -----------------------------------------------------------
Few things I'd like to see fixed before moving to integration: llversionserver.h : this change is irrelevant to the issue, take out. llversionviewer.h : same llregionflags.h : are all those changes relevant to the issue? I can see the interest of REGION_FLAGS_ALLOW_RETURN_ENCROACHING_OBJECT but what about all the other flags suppressed or commented out? Anything in there changed that shouldn't? InfoPlist.strings : don't change that, let release do this when it's necessary to release a version Info-SecondLife.plist : same viewerRes.rc : same - Merov On 2010-12-22 09:37:08, Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/56/ > ----------------------------------------------------------- > > (Updated 2010-12-22 09:37:08) > > > Review request for Viewer and Andrew Meadows. > > > Summary > ------- > > The object-vs-parcel overlap test is done by building axis-aligned bounding > boxes (AABB) about each prim of the selected objects and then checking for > overlap between those boxes and self- and group-owned parcels. > > > This addresses bug STORM-807. > http://jira.secondlife.com/browse/STORM-807 > > > Diffs > ----- > > indra/llcommon/llversionserver.h fc82190a3f0c > indra/llcommon/llversionviewer.h fc82190a3f0c > indra/llmath/llbbox.h fc82190a3f0c > indra/llmath/llbbox.cpp fc82190a3f0c > indra/llmessage/llregionflags.h fc82190a3f0c > indra/newview/English.lproj/InfoPlist.strings fc82190a3f0c > indra/newview/Info-SecondLife.plist fc82190a3f0c > indra/newview/llviewermenu.cpp fc82190a3f0c > indra/newview/llviewerobject.h fc82190a3f0c > indra/newview/llviewerobject.cpp fc82190a3f0c > indra/newview/llviewerparceloverlay.h fc82190a3f0c > indra/newview/llviewerparceloverlay.cpp fc82190a3f0c > indra/newview/llviewerregion.h fc82190a3f0c > indra/newview/llviewerregion.cpp fc82190a3f0c > indra/newview/res/viewerRes.rc fc82190a3f0c > indra/newview/skins/default/xui/en/menu_viewer.xml fc82190a3f0c > > Diff: http://codereview.secondlife.com/r/56/diff > > > Testing > ------- > > > Thanks, > > Merov > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
