----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/14/#review59 -----------------------------------------------------------
I have no technical objections to the code provided. And in fact, the code provided *should* change the functionality back to what the users are reporting is their expectation of what the behavior should be. The part that makes me nervous is that this enables an outfit operation for a class of folders that we have not allowed with the new outfit system previously. Based on other pieces on the code that would get called by this operation, I believe that the result will be that of the resident request to "revert" behavior (namely remove all clothing, remove body parts that are replaced by the new folder, leave old body parts that are necessary to display the avatar). That being said, we need a more comprehensive review of the role of incomplete outfits and how it fits with our technical architecture we've built up in our current outfits system. The code here should implement the correct behavior and I have no technical issues with it. But I want to make sure that we are aware of the risk of edge cases as we have not considered possibly popping up as a result of this patch. - Nyx On 2010-12-13 07:08:28, Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/14/ > ----------------------------------------------------------- > > (Updated 2010-12-13 07:08:28) > > > Review request for Viewer. > > > Summary > ------- > > Enabled the "Replace Current Outfit" option for incomplete outfits (i.e. > those that don't contain full set of body parts). > > > This addresses bug STORM-702. > http://jira.secondlife.com/browse/STORM-702 > > > Diffs > ----- > > indra/newview/llappearancemgr.cpp 3d2e71443c58 > indra/newview/llinventoryfunctions.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/14/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
