Roland Mainz wrote:
> Roland Mainz wrote:
> > April Chin wrote:
> [snip]
> > > ./lib/libast/common/misc/optctx.c
> >
> > These five can AFAIK be removed ("optctx.c" is a valid source file but I
> > forgot to hook it up in Makefile.com ... but nothing in the current
> > OS/Net codebase uses it and to make this issue short: remove it
> > (otherwise we need a reviewer for the one-liner and I doubt any of the
> > reviewers is still around)).
>
> Ahhggrrlrlll... this issue is so... <censored>> (my fault). The problem
> works like this:
> Somehow during a source rename something went wrong and "optctx.c" was
> accidently called "optoptctx.c". That's why "optctx.c" shows-up as
> unreferenced and optoptctx.c doesn't exist in the upstream sources but
> has the CPL license. Grrr.... this is so... <censored>.
>
> I've attached the fix for this as
> "ksh93_integration_optoptctx_rename001.diff.txt" - it removes the
> "optoptctx.c" file which is identical to "optctx.c" (therefore no extra
> review required for this file) and adjusts
> usr/src/lib/libast/Makefile.com to use the correct source...
John: John Smith <[email protected]> and C. Bergström
<[email protected]> reviewed the change... I hope that's Ok for
the RTI (the patch doesn't change any real code since "optoptctx.c" and
"optctx.c"'s code is identical. The patch still passes the
ksh93-integration test suite in the "C", "en_US.UTF-8" and
"zh_CN.GB18030" locales and basic interactive tests work, too).
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) [email protected]
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
--- Begin Message ---
> ... can anyone please review this patch ASAP, please ?
looks good, though I'm not able to test-compile your "patch"
PS: merry christmas
--
This message posted from opensolaris.org
_______________________________________________
ksh93-integration-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/ksh93-integration-discuss
--- End Message ---
--- Begin Message ---
reviewed by C. Bergstrom cbergstrom<@>netsyncro.com
This seems pretty trivial. You just removed the duplicate code and fixed
Makefile.com.
Thanks
./C
Happy Holidays
--
This message posted from opensolaris.org
_______________________________________________
ksh93-integration-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/ksh93-integration-discuss
--- End Message ---
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
