[PATCH]: bf9b1dbb65 OpenULINK firmware: fix build with sdcc versions >= 4.2.3

[gerrit]

This is an automated email from Gerrit.

"Charles Mirabile <cmira...@redhat.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9514

-- gerrit

commit bf9b1dbb6556fbfdf46ce591465b9262cd235151
Author: Charles Mirabile <cmira...@redhat.com>
Date:   Thu Mar 12 21:05:22 2026 -0400

    OpenULINK firmware: fix build with sdcc versions >= 4.2.3
    
    Since sdcc 4.2.3 the numeric parameter to `__interrupt` must be between
    parentheses.
    
    Check patch does not recognize the interrupt keyword as a function
    attribute, it thinks that they are casts and gets confused, hence:
    Checkpatch-ignore: SPACING
    
    Change-Id: I57a84f8cc2ef0bcc6def7e673bb52236d4725dda
    Signed-off-by: Charles Mirabile <cmira...@redhat.com>

diff --git a/src/jtag/drivers/OpenULINK/src/main.c 
b/src/jtag/drivers/OpenULINK/src/main.c
index 51d3a3b947..032f41c0c8 100644
--- a/src/jtag/drivers/OpenULINK/src/main.c
+++ b/src/jtag/drivers/OpenULINK/src/main.c
@@ -11,7 +11,7 @@
 #include "usb.h"
 #include "protocol.h"
 
-extern void sudav_isr(void)    __interrupt SUDAV_ISR;
+extern void sudav_isr(void)    __interrupt(SUDAV_ISR);
 extern void sof_isr(void)      __interrupt;
 extern void sutok_isr(void)    __interrupt;
 extern void suspend_isr(void)  __interrupt;
diff --git a/src/jtag/drivers/OpenULINK/src/usb.c 
b/src/jtag/drivers/OpenULINK/src/usb.c
index 408e212178..39d166ef23 100644
--- a/src/jtag/drivers/OpenULINK/src/usb.c
+++ b/src/jtag/drivers/OpenULINK/src/usb.c
@@ -118,7 +118,7 @@ __code struct usb_string_descriptor *__code 
en_string_descriptors[4] = {
        &strConfigDescr
 };
 
-void sudav_isr(void) __interrupt SUDAV_ISR
+void sudav_isr(void) __interrupt(SUDAV_ISR)
 {
        CLEAR_IRQ();
 
@@ -128,39 +128,39 @@ void sudav_isr(void) __interrupt SUDAV_ISR
        EP0CS |= HSNAK;
 }
 
-void sof_isr(void)      __interrupt SOF_ISR
+void sof_isr(void)      __interrupt(SOF_ISR)
 {
 }
-void sutok_isr(void)    __interrupt SUTOK_ISR
+void sutok_isr(void)    __interrupt(SUTOK_ISR)
 {
 }
-void suspend_isr(void)  __interrupt SUSPEND_ISR
+void suspend_isr(void)  __interrupt(SUSPEND_ISR)
 {
 }
-void usbreset_isr(void) __interrupt USBRESET_ISR
+void usbreset_isr(void) __interrupt(USBRESET_ISR)
 {
 }
-void ibn_isr(void)      __interrupt IBN_ISR
+void ibn_isr(void)      __interrupt(IBN_ISR)
 {
 }
 
-void ep0in_isr(void)    __interrupt EP0IN_ISR
+void ep0in_isr(void)    __interrupt(EP0IN_ISR)
 {
 }
-void ep0out_isr(void)   __interrupt EP0OUT_ISR
+void ep0out_isr(void)   __interrupt(EP0OUT_ISR)
 {
 }
-void ep1in_isr(void)    __interrupt EP1IN_ISR
+void ep1in_isr(void)    __interrupt(EP1IN_ISR)
 {
 }
-void ep1out_isr(void)   __interrupt EP1OUT_ISR
+void ep1out_isr(void)   __interrupt(EP1OUT_ISR)
 {
 }
 
 /**
  * EP2 IN: called after the transfer from uC->Host has finished: we sent data
  */
-void ep2in_isr(void)    __interrupt EP2IN_ISR
+void ep2in_isr(void)    __interrupt(EP2IN_ISR)
 {
        EP2_in = 1;
 
@@ -171,7 +171,7 @@ void ep2in_isr(void)    __interrupt EP2IN_ISR
 /**
  * EP2 OUT: called after the transfer from Host->uC has finished: we got data
  */
-void ep2out_isr(void)   __interrupt EP2OUT_ISR
+void ep2out_isr(void)   __interrupt(EP2OUT_ISR)
 {
        EP2_out = 1;
 
@@ -179,34 +179,34 @@ void ep2out_isr(void)   __interrupt EP2OUT_ISR
        OUT07IRQ = OUT2IR;      /* Clear OUT2 IRQ */
 }
 
-void ep3in_isr(void)    __interrupt EP3IN_ISR
+void ep3in_isr(void)    __interrupt(EP3IN_ISR)
 {
 }
-void ep3out_isr(void)   __interrupt EP3OUT_ISR
+void ep3out_isr(void)   __interrupt(EP3OUT_ISR)
 {
 }
-void ep4in_isr(void)    __interrupt EP4IN_ISR
+void ep4in_isr(void)    __interrupt(EP4IN_ISR)
 {
 }
-void ep4out_isr(void)   __interrupt EP4OUT_ISR
+void ep4out_isr(void)   __interrupt(EP4OUT_ISR)
 {
 }
-void ep5in_isr(void)    __interrupt EP5IN_ISR
+void ep5in_isr(void)    __interrupt(EP5IN_ISR)
 {
 }
-void ep5out_isr(void)   __interrupt EP5OUT_ISR
+void ep5out_isr(void)   __interrupt(EP5OUT_ISR)
 {
 }
-void ep6in_isr(void)    __interrupt EP6IN_ISR
+void ep6in_isr(void)    __interrupt(EP6IN_ISR)
 {
 }
-void ep6out_isr(void)   __interrupt EP6OUT_ISR
+void ep6out_isr(void)   __interrupt(EP6OUT_ISR)
 {
 }
-void ep7in_isr(void)    __interrupt EP7IN_ISR
+void ep7in_isr(void)    __interrupt(EP7IN_ISR)
 {
 }
-void ep7out_isr(void)   __interrupt EP7OUT_ISR
+void ep7out_isr(void)   __interrupt(EP7OUT_ISR)
 {
 }
 

--