Review: Needs Fixing
Minor improvement please
Diff comments:
>
> === modified file 'openlp/core/ui/media/mediacontroller.py'
> --- openlp/core/ui/media/mediacontroller.py 2019-05-05 05:59:29 +0000
> +++ openlp/core/ui/media/mediacontroller.py 2019-05-31 20:34:31 +0000
> @@ -131,7 +106,8 @@
> else:
> State().missing_text('media_live',
> translate('OpenLP.SlideController',
> 'VLC or pymediainfo are missing, so you are
> unable to play any media'))
> - self._generate_extensions_lists()
> + self.service_manager.supported_suffixes(AUDIO_EXT)
Would be better to pull not push the fields. Can you move to ServiceManager
> + self.service_manager.supported_suffixes(VIDEO_EXT)
> return True
>
> def bootstrap_post_set_up(self):
--
https://code.launchpad.net/~phill-ridout/openlp/media_ext_refactors/+merge/368212
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
