Review: Needs Fixing
You can use _ for unused variables.
Not convinced with the #noqa as we are not using Flake8 generally (at present)
There may be the need for Phil to do a cleanup patch to remove them in a years
time.
Diff comments:
>
> === modified file 'openlp/core/lib/projector/pjlink1.py'
> --- openlp/core/lib/projector/pjlink1.py 2017-06-17 00:25:06 +0000
> +++ openlp/core/lib/projector/pjlink1.py 2017-06-25 02:30:08 +0000
> @@ -341,7 +391,7 @@
> data = decode(read, 'utf-8')
> # Possibility of extraneous data on input when reading.
> # Clean out extraneous characters in buffer.
> - dontcare = self.readLine(self.max_size)
> + dontcare = self.readLine(self.max_size) # noqa: F841
Why not use _ as the varable if it is not wanted.
> log.debug('({ip}) check_login() read
> "{data}"'.format(ip=self.ip, data=data.strip()))
> # At this point, we should only have the initial login prompt with
> # possible authentication
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-f/+merge/326265
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
