Review: Needs Fixing
One comment below, just a minor fix. As Tomas said, if those strings are going
to be available to the user they should be translated. We don't need to worry
about how stable the strings are yet, so just go ahead and do it now before we
forget about them.
Diff comments:
>
> === modified file 'openlp/core/lib/projector/db.py'
> --- openlp/core/lib/projector/db.py 2017-05-20 05:51:58 +0000
> +++ openlp/core/lib/projector/db.py 2017-05-30 23:36:26 +0000
> @@ -243,7 +244,9 @@
> """
> def __init__(self, *args, **kwargs):
> log.debug('ProjectorDB().__init__(args="{arg}",
> kwargs="{kwarg}")'.format(arg=args, kwarg=kwargs))
> - super().__init__(plugin_name='projector',
> init_schema=self.init_schema)
> + super(ProjectorDB, self).__init__(plugin_name='projector',
It's better to use super().__init__(...) as this will correctly traverse the
inheritance tree. Tying the super() to ProjectorDB is not necessarily a good
idea.
> + init_schema=self.init_schema,
> + upgrade_mod=upgrade)
> log.debug('ProjectorDB() Initialized using db url
> {db}'.format(db=self.db_url))
> log.debug('Session: {session}'.format(session=self.session))
>
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-d/+merge/324823
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
