Review: Needs Fixing
Just one minor edit.
Diff comments:
>
> === modified file 'openlp/plugins/presentations/lib/powerpointcontroller.py'
> --- openlp/plugins/presentations/lib/powerpointcontroller.py 2017-05-14
> 10:11:10 +0000
> +++ openlp/plugins/presentations/lib/powerpointcontroller.py 2017-05-30
> 20:33:49 +0000
> @@ -542,5 +542,5 @@
> text += shape.TextFrame.TextRange.Text + '\n'
> except pywintypes.com_error as e:
> log.warning('Failed to extract text from powerpoint slide')
> - log.warning(e)
> + log.exception(e)
Actually, just remove the log.warning(e), and change the top log.warning to a
log.exception('...'). log.exception already logs the exception, you don't have
to pass it in.
> return text
--
https://code.launchpad.net/~phill-ridout/openlp/TODOne/+merge/324815
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
