On Tue, 14 Apr 2026 21:40:51 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add exports
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java
> line 2594:
>
>> 2592:
>> 2593: private final void setDocumentArea(double minX, double minY,
>> double width, double height) {
>> 2594: if (documentArea != null) {
>
> Typically a setter calls the property to create it if not already created. Is
> there a reason to instead ignore the set call in that case?
Yes, there is a reason. The document area gets updated frequently (resizing
etc.) but we don't want to create the property unless it was requested. When
it's requested, the value is initialized with the current value and then
follows the changes (externally it is a read-only property).
> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/model/TestRichExport.java
> line 66:
>
>> 64: public void simpleTextModel() {
>> 65: append("1/n2");
>> 66: verify("{}1/n2{!}");
>
> Did you mean to test newlines? If so, then you have a typo: `/n` --> `\n`. If
> you did mean forward-slash + `n` then ok.
good catch, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3089775877
PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3089777602
