On Mon, 30 Mar 2026 21:13:19 GMT, Christopher Schnick <[email protected]>
wrote:
>> This fixes issues with Alerts when the owner stage is not a valid stage with
>> a scene and currently showing
>
> Christopher Schnick has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add tests for centering
lgtm, some minor comments.
also needs `/template append` and the checkbox
modules/javafx.controls/src/test/java/test/javafx/scene/control/AlertTest.java
line 341:
> 339: }
> 340:
> 341: @Test public void alert_owner_iconifiedCentering() {
minor: we probably should place `@Test` annotations on its own line in the new
code.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2127#pullrequestreview-4107974566
PR Comment: https://git.openjdk.org/jfx/pull/2127#issuecomment-4245962740
PR Review Comment: https://git.openjdk.org/jfx/pull/2127#discussion_r3081325431
