On Fri, 10 Apr 2026 19:44:26 GMT, Marius Hanl <[email protected]> wrote:

> This PR is based on: https://github.com/openjdk/jfx/pull/1970
> The last commit of this PR can already be reviewed, but this PR will only be 
> merged after the previous PR was merged.
> 
> This is the continuation of the split of the Maven publishing. 
> Since the `build.gradle` file had become so large, adding more Maven code was 
> out of the question in the past. 
> Thanks to the split, we can now quickly and easily add support for JavaFX 
> Sources, thereby significantly simplifying testing.
> 
> This can be tested by:
> 
> `./gradlew publishToMavenLocal -PMAVEN_PUBLISH=true -PMAVEN_VERSION=custom`
> 
> This will create a JavaFX version named 'custom' in your `.m2` folder (under 
> `.m2/org/openjfx/javafx-XXX/custom`)
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

I compared the contents of the "build" folder created during the following 
Gradle commands, both with and without the changes from this PR. 

In order to compare them, I had to merge the main branch into this one, so I 
may have missed something. Nevertheless, here are my observations on build 
result with the changes from this PR:

- **gradlew all** additionally creates the source-JARs in the "publications" 
folder
- **gradlew sdk** does not create the folder "publications"
- **gradlew -PMAVEN_PUBLISH=true -PMAVEN_VERSION=XXX publishToMavenLocal** 
additionally creates the "modular-sdk" and "sdk" folders. The contents of these 
folders differ from those created by the **gradlew sdk**.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2144#issuecomment-4242314887

Reply via email to