On Sun, 12 Apr 2026 20:09:15 GMT, Marius Hanl <[email protected]> wrote:
>> This PR removes all `StubToolkit` checks from JavaFX production code. >> There are only a few. >> >> Two notes: >> >> Note 1: `TableRowSkinBase`s `DO_ANIMATIONS` is now `true` for tests. It was >> not before due to a leak (as far as I could find when digging >> [JDK-8120657](https://bugs.openjdk.org/browse/JDK-8120657)). But I could not >> find any problem, even running all tests with `-Xmx512m` >> Checking tests that trigger the affected code path and creating a heapdump >> after, I could not see anything weird: >>> Heapdump after `TreeTableViewResizeTest`: >> <img width="859" height="542" alt="image" >> src="https://github.com/user-attachments/assets/744d27f2-73e7-4213-ae6f-63b0c2b10f7a"; >> /> >> <img width="858" height="347" alt="image" >> src="https://github.com/user-attachments/assets/0a873611-ae76-4ea9-82b6-bad4cba84fd3"; >> /> >> >> Note 2: Now when the tests run in CI, `JavaFX: using >> test.com.sun.javafx.pgstub.StubToolkit` is now printed 12 times (probably >> the amount of Unit Test Threads): >> <img width="1451" height="514" alt="image" >> src="https://github.com/user-attachments/assets/c0a9f49d-5d37-4df6-a15a-4aa4cb1b4b83"; >> /> >> If this is a problem, we can decide if we want to change the print code in >> `Toolkit` (in a follow-up). >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubToolkit.java > line 784: > >> 782: } >> 783: >> 784: private KeyCode platformShortcutKey = null; > > This can be overridden by tests (`KeyCombinationTest`), otherwise the default > is used that was previously already done in `KeyBinding` and `KeyModifier`. very minor: `= null` is unnecessary. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2146#discussion_r3074250484
