On Tue, 3 Mar 2026 15:21:52 GMT, Andy Goryachev <[email protected]> wrote:
>> Yes I think there probably should be, and there also probably is a better >> way. I'm also not a big fan of just checking thread's name, especially if we >> need to change it for any reason. When working on this bug I stumbled upon >> an ancient enhancement about this - >> [JDK-8090484](https://bugs.openjdk.org/browse/JDK-8090484) - so it seems >> there were at least some theorized attempts to improve this part. >> >> I would consider it out of scope of this change though and improve this >> separately (probably as a part of the above issue), it almost certainly >> would be a larger improvement reaching over to graphics module. >> >> **EDIT:** Also, regarding `Disposer` - I suspect you meant the one residing >> in graphics under `com/sun/prism/impl/Disposer.java`. We seem to have quite >> a bit of Disposers in the code base... > > definitely out of scope for this PR. > > since it's a real (non-virtual) thread, we could create a thread of specific > type and just check `if(Thread.currentThread().getClass == > QuantumRenderer.class)` ? When fixing the follow-up, I'd rather see a `QuantumRenderer::isRenderThread` method added to encapsulate the details. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2092#discussion_r3034323267
