On Tue, 31 Mar 2026 23:49:04 GMT, Alexander Matveev <[email protected]> wrote:
> - Remove `G_DISABLE_CHECKS` compiler flag on Windows to align GLib/GStreamer > compilation with macOS/Linux. > - This should avoid potential bugs on Windows and error checks will be align > with macOS and Linux. > - Disable logging in `g_return_*` macros to reduce binary size. On Windows > binary size with `G_DISABLE_CHECKS` increased by 51,200 bytes. If logging > enabled binary size would increase by 191,488 bytes. > - Binary size of Linux and macOS will decrease since logging disabled for all > platforms. For example on macOS libglib-lite.dylib reduced from 1,427,392 > bytes to 1,184,664 and libgstreamer-lite.dylib reduced from 2,079,640 to > 1,716,928. I can provide Linux numbers if needed. > - Removed `gst_element_link_many()` which tried to link `pVideoSink` to > `NULL` and it will fail. With `G_DISABLE_CHECKS` it did not failed since > function was doing nothing and returning `TRUE`. Without `G_DISABLE_CHECKS` > it will return `FALSE` since second argument is `NULL`. Looking good. All builds and tests ran fine. I also did a small sanity check by playing media and everything still worked. ------------- Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/2134#pullrequestreview-4048754371
