On Wed, 25 Mar 2026 16:58:30 GMT, Christopher Schnick <[email protected]>
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/HeavyweightDialog.java
>> line 55:
>>
>>> 53: @Override public void centerOnScreen() {
>>> 54: Window owner = HeavyweightDialog.this.getOwner();
>>> 55: if (owner != null && owner.getScene() != null &&
>>> owner.isShowing() && (!(owner instanceof Stage ownerStage) ||
>>> !ownerStage.isIconified())) {
>>
>> A test for the new condition: `owner.isShowing() && (!(owner instanceof
>> Stage ownerStage) || !ownerStage.isIconified())` would also be a good idea
>
> This would have to be manually tested to verify that the window is properly
> centered. I think automating that is quite hard
Maybe we can just check if `x` and `y` are set or something like that?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2127#discussion_r2989712456
