On Mon, 23 Mar 2026 21:40:36 GMT, Andy Goryachev <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8379213: 3 Null pointer dereference defect groups in dlmalloc.c [v2] > > modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/dlmalloc.c > line 3386: > >> 3384: #ifdef GSTREAMER_LITE >> 3385: if (oldsp == NULL) >> 3386: return; > > does the caller expect the segment to exist and simply go ahead with whatever > it wanted to do (and break things), or it actually checks the availability > somehow? It will break things. I fixed it by handling error correctly. Not sure why I miss it initially. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2121#discussion_r2984707479
