On Tue, 24 Mar 2026 22:12:43 GMT, Marius Hanl <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 21 additional >> commits since the last revision: >> >> - review comments >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - 2026 >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - ... and 11 more: https://git.openjdk.org/jfx/compare/e4364eba...3578ed25 > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 166: > >> 164: /** >> 165: * Creates a new TabPaneSkin instance, installing the necessary >> child >> 166: * nodes into the Control {@link >> javafx.scene.control.Control#getChildren() children} list, as > > I would vote +1 to change this in all Skins, but obviously very minor I think I removed the `Control` import and it broke javadoc, which I only saw in GHA. Actually, it should be Parent.getChildren() , and maybe say `nodes into the control's {@link javafx.scene.Parent#getChildren() children} list` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1773#discussion_r2984642327
