On Mon, 23 Mar 2026 22:25:15 GMT, Alexander Matveev <[email protected]>
wrote:
>> modules/javafx.media/src/main/native/gstreamer/3rd_party/glib/glib/gvariant-serialiser.c
>> line 994:
>>
>>> 992: *out_member_start = 0;
>>> 993: if (out_member_end != NULL)
>>> 994: *out_member_end = 0;
>>
>> I *really* dislike the absence of { }'s here...
>>
>> Are *out_member_start and *out_member_end the only fields that need to be
>> cleared here?
>
> Yes, all other parameters are read only. If you scroll down to the end of
> this function you will see exactly same code without {}. Most code in
> GLib/GStreamer does not use {} in single line if statements. When doing fixes
> I am trying to match formatting of GLib/GStreamer as much as possible.
ok, I won't insist. but multiple nested levels of ifs without curly braces is
just a bad idea. I've seen too many of
if(condition)
a();
b();
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2122#discussion_r2977941278
