On Thu, 15 Jan 2026 16:47:28 GMT, John Hendrikx <[email protected]> wrote:
>> This new check is much more accurate to detect whether a parent is currently >> laying out its children. The previous code almost never worked, resulting in >> additional unnecessary layouts. > > John Hendrikx has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into feature/in-layoutchildren-detection-for-node > - Rename test > - Add regression test > - Fix ToolBarSkinTest > > Reusing a toolbar as part of several scenes, in combination with the > StubToolkit that doesn't handle pulses makes this test fail with the relayout > detection fix. > - Change how Node detects whether a relayout is required > > This new check is much more accurate to detect whether a parent is > currently laying out its children. The previous code almost never worked, > resulting in additional unnecessary layouts. So this regression has not been addressed: <img width="521" height="126" alt="Image" src="https://github.com/user-attachments/assets/8bc7c2b7-5b50-4e43-a14f-405644e54ea0"; /> this happens when the MT opens on an external monitor at scale=1 (??). move the window to retina scale=2, and it looks normal. move the window back to external - ellipses appear again. modules/javafx.graphics/src/main/java/javafx/scene/Parent.java line 1298: > 1296: for (int i = 0, max = children.size(); i < max; i++) { > 1297: final Node child = children.get(i); > 1298: very very minor: since you are touching the file, perhaps you _could_ make the equivalent change: if (child instanceof Parent cp) { cp.layout(); } else if (child instanceof SubScene cs) { cs.layoutPass(); } ------------- Changes requested by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1945#pullrequestreview-3956566270 PR Review Comment: https://git.openjdk.org/jfx/pull/1945#discussion_r2942881214
