On Fri, 6 Mar 2026 23:49:11 GMT, Philemon Hilscher <[email protected]> wrote:

> This PR removes the obsolete caller class field from the FXMLLoader as it is 
> requested by the ticket and comment in the class. The caller class loader in 
> the ControllerAccessor is therefore obsolete and has been removed as well.
> 
> Edit: I've found another caller parameter in getDefaultClassLoader(), which 
> was always null. Also removed :)

looks good, one minor comment.

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1147:

> 1145:             fxmlLoader.setStaticLoad(staticLoad);
> 1146: 
> 1147:             Object value = fxmlLoader.loadImpl();

Line 2: please update copyright year
` * Copyright (c) 2010, 2026, `

-------------

PR Review: https://git.openjdk.org/jfx/pull/2099#pullrequestreview-3937487380
PR Review Comment: https://git.openjdk.org/jfx/pull/2099#discussion_r2925393120

Reply via email to