On Fri, 6 Mar 2026 19:54:10 GMT, Jose Pereda <[email protected]> wrote:
>> This PR adds a fix to prevent a crash on macOS after exiting full screen >> mode when a modal dialog is showing >> (https://bugs.openjdk.org/browse/JDK-8371370). >> >> At the same time, it prevents non-resizable windows from entering full >> screen mode (https://bugs.openjdk.org/browse/JDK-8379315), given that the >> changes for both issues were interrelated. >> >> While no tests have been added, manual tests have been run, checking that >> the style mask, the window behavior and the standard window buttons state, >> remained consistent in different scenarios. >> >> Also, according to >> https://developer.apple.com/documentation/appkit/nswindow/showsresizeindicator, >> the `showsResizeIndicator` property has been removed. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > fix typo and remove unused property This PR is causing some of the tests in PR #1789 to fail. I think the tests are timing out while trying to put UNDECORATED stages into fullscreen mode. This is another murky area in the spec. The description of setResizable() states that turning the flag off doesn't prevent API calls from changing the window size. Historically it seems we've interpreted that to mean that non-resizable stages can be maximized and enter fullscreen mode. There's code on the macOS side to handle the fullscreen case (setResizableForFullscreen:). That assumption has made its way into the tests. The tests in #1789 are FullScreenTest and StageAttributesTest (testFullScreenStage and testFullScreenStageBeforeShow). The timeouts seem to be preventing proper cleanup so I'm also seeing some bogus failures after the first one. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2098#issuecomment-4026272047
