On Tue, 28 Nov 2023 07:00:36 GMT, John Hendrikx <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> combine
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 344:
>
>> 342: List<CssMetaData<? extends Styleable, ?>> list,
>> 343: CssMetaData<? extends Styleable, ?>... items)
>> 344: {
>
> The method is not actually making use of `CssMetaData`, so a more generic
> utility method would have worked as well:
>
> public static <T> List<T> combine(List<T> list, T... items)
>
> It could be placed in some kind of utility class (and in fact, many libs
> offer such a method already).
Yeah, perhaps even in List?
JavaFX does not provide a common utility package, and I am trying to limit the
scope by narrowing the accepted data type here.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1296#discussion_r1407963566
