On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker <[email protected]> wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and > `DateStringConverter` after it was removed already in > `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter` > (and subclasses). CSR is needed (I see you already issued a / csr command). LGTM You are right, constructor that accepts the format is enough. It's just weird - allowing core classes to override yet denying this freedom to the app dev. On the other hand, they can always extend StringConverter. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1294#pullrequestreview-1743314319 PR Comment: https://git.openjdk.org/jfx/pull/1294#issuecomment-1821849974
