tree: https://github.com/cminyard/linux-ipmi for-next head: 90478a78b71fffa35ecaca82d229036fcd9a4a58 commit: 90478a78b71fffa35ecaca82d229036fcd9a4a58 [6/6] ipmi: ssif_bmc: add unit test for state machine config: x86_64-randconfig-071-20260403 (https://download.01.org/0day-ci/archive/20260403/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260403/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): drivers/char/ipmi/ssif_bmc.c: In function 'ssif_bmc_remove': drivers/char/ipmi/ssif_bmc.c:865:9: error: implicit declaration of function 'del_timer_sync' [-Wimplicit-function-declaration] 865 | del_timer_sync(&ssif_bmc->response_timer); | ^~~~~~~~~~~~~~ In file included from include/linux/cleanup.h:5, from include/linux/acpi.h:11, from include/linux/i2c.h:13, from drivers/char/ipmi/ssif_bmc.c:9: drivers/char/ipmi/ssif_bmc.c: In function 'ssif_bmc_test_singlepart_read_response_completion': >> drivers/char/ipmi/ssif_bmc.c:1064:43: error: 'struct ssif_bmc_ctx' has no >> member named 'response_in_send'; did you mean 'response_timer'? 1064 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:32:55: note: in definition of macro '__branch_check__' 32 | ______r = __builtin_expect(!!(x), expect); \ | ^ include/kunit/test.h:786:13: note: in expansion of macro 'likely' 786 | if (likely(!!(condition_) == !!expected_true_)) \ | ^~~~~~ include/kunit/test.h:800:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION' 800 | KUNIT_UNARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:996:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION' 996 | KUNIT_TRUE_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:993:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE_MSG' 993 | KUNIT_EXPECT_TRUE_MSG(test, condition, NULL) | ^~~~~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1064:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE' 1064 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~~ >> drivers/char/ipmi/ssif_bmc.c:1064:43: error: 'struct ssif_bmc_ctx' has no >> member named 'response_in_send'; did you mean 'response_timer'? 1064 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:34:54: note: in definition of macro '__branch_check__' 34 | expect, is_constant); \ | ^~~~~~~~~~~ include/kunit/test.h:786:13: note: in expansion of macro 'likely' 786 | if (likely(!!(condition_) == !!expected_true_)) \ | ^~~~~~ include/kunit/test.h:800:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION' 800 | KUNIT_UNARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:996:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION' 996 | KUNIT_TRUE_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:993:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE_MSG' 993 | KUNIT_EXPECT_TRUE_MSG(test, condition, NULL) | ^~~~~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1064:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE' 1064 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1088:44: error: 'struct ssif_bmc_ctx' has no member named 'response_in_send'; did you mean 'response_timer'? 1088 | KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:32:55: note: in definition of macro '__branch_check__' 32 | ______r = __builtin_expect(!!(x), expect); \ | ^ include/kunit/test.h:786:13: note: in expansion of macro 'likely' 786 | if (likely(!!(condition_) == !!expected_true_)) \ | ^~~~~~ include/kunit/test.h:808:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION' 808 | KUNIT_UNARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1015:9: note: in expansion of macro 'KUNIT_FALSE_MSG_ASSERTION' 1015 | KUNIT_FALSE_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1012:9: note: in expansion of macro 'KUNIT_EXPECT_FALSE_MSG' 1012 | KUNIT_EXPECT_FALSE_MSG(test, condition, NULL) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1088:9: note: in expansion of macro 'KUNIT_EXPECT_FALSE' 1088 | KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1088:44: error: 'struct ssif_bmc_ctx' has no member named 'response_in_send'; did you mean 'response_timer'? 1088 | KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:34:54: note: in definition of macro '__branch_check__' 34 | expect, is_constant); \ | ^~~~~~~~~~~ include/kunit/test.h:786:13: note: in expansion of macro 'likely' 786 | if (likely(!!(condition_) == !!expected_true_)) \ | ^~~~~~ include/kunit/test.h:808:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION' 808 | KUNIT_UNARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1015:9: note: in expansion of macro 'KUNIT_FALSE_MSG_ASSERTION' 1015 | KUNIT_FALSE_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1012:9: note: in expansion of macro 'KUNIT_EXPECT_FALSE_MSG' 1012 | KUNIT_EXPECT_FALSE_MSG(test, condition, NULL) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1088:9: note: in expansion of macro 'KUNIT_EXPECT_FALSE' 1088 | KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c: In function 'ssif_bmc_test_write_interrupts_response_send': drivers/char/ipmi/ssif_bmc.c:1191:43: error: 'struct ssif_bmc_ctx' has no member named 'response_in_send'; did you mean 'response_timer'? 1191 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:32:55: note: in definition of macro '__branch_check__' 32 | ______r = __builtin_expect(!!(x), expect); \ | ^ include/kunit/test.h:786:13: note: in expansion of macro 'likely' 786 | if (likely(!!(condition_) == !!expected_true_)) \ | ^~~~~~ include/kunit/test.h:800:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION' 800 | KUNIT_UNARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:996:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION' 996 | KUNIT_TRUE_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:993:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE_MSG' 993 | KUNIT_EXPECT_TRUE_MSG(test, condition, NULL) | ^~~~~~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1191:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE' 1191 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~~ drivers/char/ipmi/ssif_bmc.c:1191:43: error: 'struct ssif_bmc_ctx' has no member named 'response_in_send'; did you mean 'response_timer'? 1191 | KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:34:54: note: in definition of macro '__branch_check__' 34 | expect, is_constant); \ | ^~~~~~~~~~~ include/kunit/test.h:786:13: note: in expansion of macro 'likely' 786 | if (likely(!!(condition_) == !!expected_true_)) \ | ^~~~~~ include/kunit/test.h:800:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION' 800 | KUNIT_UNARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:996:9: note: in expansion of macro 'KUNIT_TRUE_MSG_ASSERTION' 996 | KUNIT_TRUE_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:993:9: note: in expansion of macro 'KUNIT_EXPECT_TRUE_MSG' vim +1064 drivers/char/ipmi/ssif_bmc.c 1042 1043 static void ssif_bmc_test_singlepart_read_response_completion(struct kunit *test) 1044 { 1045 struct ssif_bmc_test_ctx *test_ctx = test->priv; 1046 struct ssif_bmc_ctx *ssif_bmc = &test_ctx->ssif_bmc; 1047 u8 value; 1048 1049 ssif_bmc->state = SSIF_SMBUS_CMD; 1050 ssif_bmc->part_buf.smbus_cmd = SSIF_IPMI_SINGLEPART_READ; 1051 ssif_bmc->response.len = 2; 1052 ssif_bmc->response.payload[0] = 0x11; 1053 ssif_bmc->response.payload[1] = 0x22; 1054 ssif_bmc->response_in_progress = true; 1055 ssif_bmc->is_singlepart_read = true; 1056 ssif_bmc->pec_support = true; 1057 1058 value = 0; 1059 KUNIT_ASSERT_EQ(test, 1060 ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_REQUESTED, 1061 &value), 0); 1062 KUNIT_EXPECT_EQ(test, value, 2); 1063 KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_RES_SENDING); > 1064 KUNIT_EXPECT_TRUE(test, ssif_bmc->response_in_send); 1065 1066 value = 0; 1067 KUNIT_EXPECT_EQ(test, 1068 ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, 1069 &value), 0); 1070 KUNIT_EXPECT_EQ(test, value, 0x11); 1071 1072 value = 0; 1073 KUNIT_EXPECT_EQ(test, 1074 ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, 1075 &value), 0); 1076 KUNIT_EXPECT_EQ(test, value, 0x22); 1077 1078 value = 0; 1079 KUNIT_EXPECT_EQ(test, 1080 ssif_bmc_test_run_event_val(test_ctx, I2C_SLAVE_READ_PROCESSED, 1081 &value), 0); 1082 KUNIT_EXPECT_EQ(test, value, ssif_bmc->part_buf.pec); 1083 1084 KUNIT_EXPECT_EQ(test, 1085 ssif_bmc_test_run_event(test_ctx, I2C_SLAVE_STOP, 0), 0); 1086 KUNIT_EXPECT_EQ(test, ssif_bmc->state, SSIF_READY); 1087 KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_progress); 1088 KUNIT_EXPECT_FALSE(test, ssif_bmc->response_in_send); 1089 KUNIT_EXPECT_EQ(test, ssif_bmc->response.len, 0); 1090 } 1091 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
