…
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -3734,6 +3734,7 @@ int ipmi_add_smi(struct module *owner,
> sysfs_attr_init(&intf->maintenance_mode_devattr.attr);
> rv = device_create_file(intf->si_dev, &intf->maintenance_mode_devattr);
> if (rv) {
> + device_remove_file(intf->si_dev, &intf->nr_msgs_devattr);
> device_remove_file(intf->si_dev, &intf->nr_users_devattr);
> goto out_err_bmc_reg;
> }
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.0-rc5#n526
Regards,
Markus
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
