> Well, randomness is a resource after all, and since we don't have the
> additional
> security provided by PSNs in IPoIB UD, it seemed we do not need it for
> IPoIB CM either. So maybe the right thing is just to remove the FIXME
> comment.
random32() doesn't use up any entropy. Random PSNs help avoid problems
with stale connections, so I think we should do it.
I noticed some funny code in ipoib_cm_skb_reap():
__be32 mtu = cpu_to_be32(priv->mcast_mtu);
// htonl(__be32)??
icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
htonl(mtu));
// no htonl() here -- is this correct?
icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu, dev);
what is the right thing?
- R.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
