> + if ((ret =
> ib_init_ah_from_path(priv->ca,priv->port,pathrec,&av)))
kernel style is spaces after commas, like
ib_init_ah_from_path(priv->ca, priv->port, pathrec, &av)
also, I really prefer to see code like this written as
ret = ib_init_ah_from_path(priv->ca, priv->port, pathrec, &av);
if (ret) {
If the call fails, do you think
> + ipoib_dbg(priv, "PathRec init_ah failed %d for GID "
printing the error message with ipoib_dbg() is a good idea? It means
the failure will be invisible unless someone explicitly enables
debugging.
> + // FIXME: Should this be in ib_init_ah_from_path?
> + av.static_rate = pathrec->rate;
Yes, I think this should be in ib_init_ah_from_path() ... I don't see
any reason why it shouldn't. I suspect the reason is historical,
because ib_init_ah_from_path() predates the switch to having
av.static_rate mean the real data rate of to use (rather than the
relative inter-packet delay static rate that the IB spec for verbs
talks about).
BTW do SRP and iSER already work through routers?
- R.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
