> > > +/* > > > + * Limit CM msg timeouts to something reasonable. > > > + * 8 seconds, with up to 15 retries, gives per msg timeout of 2 min. > > > + */ > > > +#define IB_CM_MAX_TIMEOUT 21 > > > > OK... (although 8 seconds seems a little short -- it seems a somewhat > > longer timeout could be legitimate on a very busy fabric across a WAN > > or something like that) > > I included retries in the overall time, we could bump this to 23 = 32 seconds > per message, and a total potential timeout of 8 minutes.
I think that's excessive. > > but then... > > > > > + timeout = min(IB_CM_MAX_TIMEOUT, > > > + > > cm_convert_to_ms(cm_mra_get_service_timeout(mra_msg)) + > > > + > > cm_convert_to_ms(cm_id_priv->av.packet_life_time)); > > > > should the IB_CM_MAX_TIMEOUT be inside a cm_convert_to_ms() too? > > and similarly... > > Several of these are off. So - an updated patch? -- MST _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
