> While importing these patches, I got several "Space in indent is
> followed by a tab." errors. For example, the line
>> + __constant_cpu_to_be16(ETH_P_8021Q))) {
I did test my patches with git-apply --whitespace=error-all,
before mailing them but did not see any error.
I am using GIT 1.3, may be I should upgrade ?
It will be great if you can share the options you use
for applying patches. That way I can test them properly before
mailing out to you.
> which also leads to the comment that there's no reason for
> __constant_cpu_to_be16() here -- just use cpu_to_be16 and let the
> compiler do the optimization. (the __constant form is only needed in
> places where the function call is a syntax error)
Thanks for explaining that. I will convert these back to cpu_to_beXX
and also work on the other naming related suggestions you had.
Regards,
Ram
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
