+Gobinath . <[email protected]> On Wed, Nov 14, 2018 at 6:47 PM Abhijit Kumbhare <[email protected]> wrote:
> I do not actually remember this - but I have a vague recollection that the > JobCoordinator was first implemented in OpenFlow Plugin by Shuva and folks > and then it may have got moved to Infra Utils later by some other people. > Perhaps you are right that this is the original ancient history, but meanwhile it went to genius, and from there into infrautils. But this NodeConfigurator & Co. is much more recent - judging from git blame, it seems that was commited only a few months ago, Aug 1st, by Gobinath for https://jira.opendaylight.org/browse/OPNFLWPLUG-991, according to the Commit Message. The only difference between NodeConfigurator and JobCoordinator is that it returns ListenableFuture<T> ... that reminds me of https://jira.opendaylight.org/browse/INFRAUTILS-16 and https://git.opendaylight.org/gerrit/#/c/69660/ - what happened there? That was WIP and were reviewing it, but the build never passed - so you just forked and copy pasted, the entire thing? Gobinath, would you be willing to finish up https://git.opendaylight.org/gerrit/#/c/69660/ rather sooner than later, and then replace this fork of infratuils' JobCoordinator in OpenFlowPlugin? > On Wed, Nov 14, 2018 at 9:21 AM Michael Vorburger <[email protected]> > wrote: > >> Hello, >> >> while working on https://git.opendaylight.org/gerrit/#/c/77796/, I've >> stumbled >> upon org.opendaylight.openflowplugin.applications.frm.NodeConfigurator, >> which looks like a "rip off" from infrautils' JobCoordinator - you guys >> seriously just copy/pasted that entire thing?! Seriously? Why don't you >> just use infrautils? >> >> Tx, >> M. >> -- >> Michael Vorburger, Red Hat >> [email protected] | IRC: vorburger @freenode | ~ = http://vorburger.ch >> _______________________________________________ >> openflowplugin-dev mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >> >
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
