> -----Original Message----- > From: Kieran Bingham <[email protected]> > Sent: Tuesday, October 3, 2023 4:29 AM > To: Tom Hochstein <[email protected]>; openembedded- > [email protected] > Cc: Tom Hochstein <[email protected]> > Subject: Re: [meta-multimedia][PATCH] libcamera: Avoid build break in > signature recalculation > > Quoting Tom Hochstein (2023-10-02 18:36:44) > > The signature recalculation task can fail: > > ``` > > /.../build/tmp/work/armv8a-poky-linux/libcamera/1_0.0.4- > r0/temp/run.do_recalculate_ipa_signatures_package.937421: line 154: > /.../build/tmp/work/armv8a-poky-linux/libcamera/1_0.0.4- > r0/git/src/ipa/ipa-sign-install.sh: No such file or directory > > ``` > > > > This happens whenever ${S} is removed and packages are retrieved from > > sstate cache. > > > > Instead of trying to fix the task, avoid the issue altogether by > > performing the signature recalculation directly in do_package. > > Will this still happen after any calls to strip? (i.e. the binaries will > not be modified after this step?)
Yes. The run.do_package script does have the recalculation call as the final line in the do_package function, which is after the call to split_and_strip. > > -- > Kieran > > > > > > Signed-off-by: Tom Hochstein <[email protected]> > > --- > > .../recipes-multimedia/libcamera/libcamera_0.1.0.bb | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/meta-multimedia/recipes- > multimedia/libcamera/libcamera_0.1.0.bb b/meta-multimedia/recipes- > multimedia/libcamera/libcamera_0.1.0.bb > > index ece1be6f3..2a3c6473e 100644 > > --- a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb > > +++ b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb > > @@ -50,8 +50,11 @@ do_install:append() { > > chrpath -d ${D}${libexecdir}/libcamera/v4l2-compat.so > > } > > > > -addtask do_recalculate_ipa_signatures_package after do_package before > do_packagedata > > -do_recalculate_ipa_signatures_package() { > > +do_package:append() { > > + bb.build.exec_func("do_package_recalculate_ipa_signatures", d) > > +} > > + > > +do_package_recalculate_ipa_signatures() { > > local modules > > for module in $(find ${PKGD}/usr/lib/libcamera -name "*.so.sign"); do > > module="${module%.sign}" > > -- > > 2.25.1 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#105322): https://lists.openembedded.org/g/openembedded-devel/message/105322 Mute This Topic: https://lists.openembedded.org/mt/101717496/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
