Also missing Signed-off-by line.

On Fri, Sep 29, 2017 at 7:37 PM, Tim Orling <
[email protected]> wrote:

>
> > On Sep 29, 2017, at 1:26 AM, Guy Morand <[email protected]> wrote:
> >
> > —
> > <snip>
> > diff --git a/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
> b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
> > new file mode 100644
> > index 0000000..f4c486b
> > --- /dev/null
> > +++ b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
> > @@ -0,0 +1,10 @@
> > +inherit setuptools
> > +require python-pandas.inc
> > +
> > +RDEPENDS_${PN} += " \
> > +  ${PYTHON_PN}-json \
> > +  ${PYTHON_PN}-importlib \
> > +  "
> > +
> > +SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
> > +SRC_URI[sha256sum] = “a777e07633d83d546c557064201795
> 51c8e01075b53c497dcf8ae4036766bc66"
>
> These SRC_URI checksum lines should go in the python-pandas.inc file,
> rather than duplicate them in both the python-pandas and python3-pandas
> files.
>
> It is quite common now for the “version specific” files to only be the
> “inherit” line and the “require foo.inc” line.
>
> DRY and KISS.
>
> > diff --git a/meta-python/recipes-devtools/python/python3-
> pandas_0.20.3.bb b/meta-python/recipes-devtools/python/python3-
> pandas_0.20.3.bb
> > new file mode 100644
> > index 0000000..81dd360
> > --- /dev/null
> > +++ b/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
> > @@ -0,0 +1,5 @@
> > +inherit setuptools3
> > +require python-pandas.inc
> > +
> > +SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
> > +SRC_URI[sha256sum] = "a777e07633d83d546c557064201795
> 51c8e01075b53c497dcf8ae4036766bc66"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > [email protected]
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> [email protected]
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Reply via email to