On 08/05/2014 05:53 PM, Richard Purdie wrote:
On Tue, 2014-08-05 at 16:33 +0800, Chong Lu wrote:
We use PTEST_ENABLED to decide whether build ptest package, so inherit
ptest.bbclass in dbus.inc in order to using PTEST_ENABLED variable.
Remove PACKAGES and ALLOW_EMPTY, since they have been defined in ptest.bbclass.
Signed-off-by: Chong Lu <[email protected]>
---
meta/recipes-core/dbus/dbus.inc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index d38ba7e..6268103 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -8,10 +8,13 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
DEPENDS = "expat virtual/libintl"
RDEPENDS_dbus_class-native = ""
RDEPENDS_dbus_class-nativesdk = ""
-PACKAGES += "${@bb.utils.contains('PTEST_ENABLED', '1', 'dbus-ptest', '', d)}"
-ALLOW_EMPTY_dbus-ptest = "1"
I don't think you've understood what this is doing, its conditionally
building the separate dbus-ptest recipe, if ptest is enabled.
Why is it separate? dbus-ptest needs glib and glib needs dbus. Your
patch doesn't seem to account for any of that.
"fix ptest issue" is far too vague as a summary of this patch too.
Cheers,
Richard
Hi Richard,
Previously, we use DISTRO_FEATURES to decide whether build ptest, but we
use PTEST_ENABLED now.
PTEST_ENABLED defined in ptest.bbclass. we did't inherit ptest in dbus
recipes, this cause we can't build dbus-ptest package.
Based on above reason, I just send this patch to fix this issue. Or do
you have a better way?
Best Regards
Chong
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
