Hi Saul,

On 26.07.2013 21:52, Saul Wold wrote:
On 07/26/2013 05:35 AM, Jukka Rissanen wrote:
oFono test scripts are very useful so enable those by default.

Signed-off-by: Jukka Rissanen <[email protected]>
---
  meta/recipes-connectivity/ofono/ofono.inc     | 3 ++-
  meta/recipes-connectivity/ofono/ofono_1.12.bb | 3 ---
  2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-connectivity/ofono/ofono.inc
b/meta/recipes-connectivity/ofono/ofono.inc
index d825496..c5bd4d0 100644
--- a/meta/recipes-connectivity/ofono/ofono.inc
+++ b/meta/recipes-connectivity/ofono/ofono.inc
@@ -15,6 +15,7 @@ INITSCRIPT_PARAMS = "defaults 22"
  EXTRA_OECONF += "\
      ${@base_contains('DISTRO_FEATURES', 'systemd',
'--with-systemdunitdir=${systemd_unitdir}/system/',
'--with-systemdunitdir=', d)} \
      ${@base_contains('DISTRO_FEATURES',
'bluetooth','--enable-bluetooth', '--disable-bluetooth', d)} \
+    --enable-test \
  "
  SYSTEMD_SERVICE_${PN} = "ofono.service"

@@ -30,5 +31,5 @@ PACKAGES =+ "${PN}-tests"
  RDEPENDS_${PN} += "dbus"

  FILES_${PN} += "${base_libdir}/udev ${systemd_unitdir}"
-FILES_${PN}-tests = "${libdir}/ofono"
+FILES_${PN}-tests = "${libdir}/${BPN}/test"
I think you should be using the ptest here instead of test and inherit
ptest, please see the ptest.bbclass.

I realize that this is not new code, but if we are going to changes this
we should use the new ptest mechanism.

Sau!


If I am reading https://wiki.yoctoproject.org/wiki/Ptest correctly, the ptest if for running the package test suite. Unfortunately the ofono-tests package is not for that purpose, it is just a bunch of useful python scripts for setting up cellular modem, context and monitoring ofono signals etc.
Similar scripts are also found in connman and neard packages.


Cheers,
Jukka

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to