Hello Chistos,

Le mar. 25 févr. 2025 à 10:58, Christos Gavros <[email protected]> a écrit :

> If the build-st/conf/local.conf does not end with a newline
> when is generated then add one
> Fixes [YOCTO #15734]
>
> CC: Randy MacLeod <[email protected]>
> Reviewed-by: Yoann Congal <[email protected]>
>
FYI, you can't add a Reviewed-by from someone without an explicit email
(Often stating the full line "Reviewed-by: Xxx Yyy <...@...>").
On your v1, I merely commented, that is not sufficient for adding my
reviewed-by.

Signed-off-by: Christos Gavros <[email protected]>
> ---
> v1->v2
> * the comment is changed
> * last_line is initialized to "None"
> * add a new line by using f.write("\n")
> ---
>  meta/lib/oeqa/selftest/context.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/context.py
> b/meta/lib/oeqa/selftest/context.py
> index 5eb4cc44fd..9145cbd72b 100644
> --- a/meta/lib/oeqa/selftest/context.py
> +++ b/meta/lib/oeqa/selftest/context.py
> @@ -102,6 +102,15 @@ class OESelftestTestContext(OETestContext):
>          oe.path.copytree(builddir + "/cache", newbuilddir + "/cache")
>          oe.path.copytree(selftestdir, newselftestdir)
>
> +        # if the last line of local.conf in newbuilddir is not empty and
> does not end with newline then add one
> +        localconf_path = newbuilddir + "/conf/local.conf"
> +        with open(localconf_path, "r+", encoding="utf-8") as f:
> +            last_line = None
> +            for line in f:
> +                last_line = line
> +            if last_line and not last_line.endswith("\n"):
> +                f.write("\n")
> +
>          subprocess.check_output("git init && git add * && git commit -a
> -m 'initial'", cwd=newselftestdir, shell=True)
>
>          # Tried to used bitbake-layers add/remove but it requires recipe
> parsing and hence is too slow
> --
> 2.34.1
>
>

-- 
Yoann Congal
Smile ECS - Tech expert
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#211870): 
https://lists.openembedded.org/g/openembedded-core/message/211870
Mute This Topic: https://lists.openembedded.org/mt/111374750/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to