On Wed, 2024-11-20 at 16:32 +0100, Alexander Kanavin via lists.openembedded.org wrote: > From: Alexander Kanavin <[email protected]> > > zstd uses 3 by default (and ZSTD_COMPRESSION_LEVEL is set to that), > while 19 is the highest and slowest. > > It's not clear why 19 was picked to begin with, possibly > I copy-pasted it from rpm's examples without thinking: > https://git.yoctoproject.org/poky/commit/?h=master-next&id=4a4d5f78a6962dda5f63e9891825c80a8a87bf66 > > This brings significant speedups in rpm's compression step: > for example compressing webkitgtk takes 11s instead of 36s. > > The rpm size increases from 175648k to 234860k. I think it's > a worthy default tradeoff. > > Signed-off-by: Alexander Kanavin <[email protected]> > > zstd fixup > > Signed-off-by: Alexander Kanavin <[email protected]> > --- > meta/classes-global/package_rpm.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-global/package_rpm.bbclass > b/meta/classes-global/package_rpm.bbclass > index ddc4bf3a6a5..fab8f568781 100644 > --- a/meta/classes-global/package_rpm.bbclass > +++ b/meta/classes-global/package_rpm.bbclass > @@ -10,7 +10,7 @@ IMAGE_PKGTYPE ?= "rpm" > > RPM = "rpm" > RPMBUILD = "rpmbuild" > -RPMBUILD_COMPMODE ?= "${@'w19T%d.zstdio' % int(d.getVar('ZSTD_THREADS'))}" > +RPMBUILD_COMPMODE ?= "${@'w%dT%d.zstdio' % > (int(d.getVar('ZSTD_COMPRESSION_LEVEL')), int(d.getVar('ZSTD_THREADS')))}" > > PKGWRITEDIRRPM = "${WORKDIR}/deploy-rpms"
There are some nice steps on the performance charts: https://valkyrie.yocto.io/pub/non-release/20241130-20/testresults/buildperf-alma8/perf-alma8-vk_master_20241130030029_2a163834b0.html https://valkyrie.yocto.io/pub/non-release/20241130-17/testresults/buildperf-debian11/perf-debian12-vk_master_20241130040023_2a163834b0.html I'm trying to trigger some specific builds so we can more precisely point to the change but this is the most likely candidate in that range :) Nice to see things speed up for a change, thanks! Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#208039): https://lists.openembedded.org/g/openembedded-core/message/208039 Mute This Topic: https://lists.openembedded.org/mt/109685843/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
