On 07.11.24 22:40, Ross Burton wrote:
On 6 Nov 2024, at 18:30, Konrad Weihmann via lists.openembedded.org
<[email protected]> wrote:
On Tue, Nov 5, 2024 at 01:56 PM, Ross Burton wrote:
I find that patch incredibly risky, as there is no really opt-out.
As the main beneficiary is pandas (which is not in core), which not add it
there as a patch?
You can opt out by setting PARALLEL_MAKE to -j1. Pandas is where I noticed,
but I expect it will make a difference for any package that builds extensions
with setuptools.
Also other suggest that all that can be achieved with --global-option="build_ext"
--global-option="-j5"
set by PEP517_BUILD_OPTS, which would find the much better options here.
Something like
PARALLEL_PEP517_BUILD ?= " --global-option="build_ext" --global-option="-j<job
count>""
PEP517_BUILD_OPTS:append = " ${PARALLEL_PEP517_BUILD}”
That’s possibly a neater solution, yes. I tried using global-option but
couldn’t get it to work right.
Ross
Maybe as an addition, why I would like this feature to added in a very
transparent and easy to undo way:
https://github.com/pypa/setuptools/issues/3119 - I'm a bit worried that in the
wider ecosystem things will
fall apart easily, if parallel builds are the default.
And as comment for the v2 of the patch:
I believe --bdist-dir does set the build dir to a path of your choice already
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#206857):
https://lists.openembedded.org/g/openembedded-core/message/206857
Mute This Topic: https://lists.openembedded.org/mt/109415037/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
