On Tue, 27 Aug 2024 at 14:50, Quentin Schulz <[email protected]> wrote: > > Hi Dmitry, > > On 8/27/24 1:35 PM, Dmitry Baryshkov wrote: > > Hi Quentin, > > > > Excuse me, I missed your review before sending v2. > > > > On Tue, 27 Aug 2024 at 13:25, Quentin Schulz <[email protected]> > > wrote: > >> > >> Hi Dmitry, > >> > >> On 8/27/24 12:09 PM, Dmitry Baryshkov via lists.openembedded.org wrote: > >>> Release 20240811 has restructured the locations of Qualcomm VPU > >>> firmware. Follow those changes and implement a single > >>> linux-firmware-qcom-vpu package holding all VPU firmware files. Use > >>> RPROVIDES to provide previously defined names. > >>> > >> > >> It'd be nice to hint at the commits in linux-firmware that do this reorg > >> for reference? > > > > Ack > > > >> > >> It's also not necessarily required to merge those together as we could > >> probably still have two different packages to avoid bringing in files we > >> don't need (I assume the same SoC doesn't have both a VPU 1.0 and a VPU > >> 2.0 ?). > > > > First of all, the original naming seems to be incorrect as > > demonstrated by the new file names: > > > > qcom/{vpu-1.0/venus.mbn => vpu/vpu20_p4.mbn} | Bin > > qcom/{vpu-2.0/venus.mbn => vpu/vpu20_p1.mbn} | Bin > > qcom/{vpu-3.0/vpu30_4v.mbn => vpu/vpu30_p4.mbn} | Bin > > > > It is possible to split one file per package and let users pick up > > packages one by one, but granted that the whole size of the directory > > (4 different firmware files) is 4.3 MiB, it doesn't seem to make sense > > to me. > > > > 4.3MiB is quite a lot if you want to be able to have a tiny filesystem :)
Well, these devices come with 64 GiB or 128 GiB UFS storage, so no need to be that picky. > > Ok so, if this > (https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=36db650dae038be945fb04def591fc726255b09f) > is the commit doing the change, we have an issue. We also need to > maintain backward compatibility, not between different versions of > Yocto/OE but between different versions of the kernel (I assume to be > the reason of the need for backward compatibility). > > See that they mention in the commit log that they provide > backwards-compatible links, we need those as well. Otherwise we may > broke older kernels we were compatible with in the past. > > I did something similar to that in a previous update, c.f. > cdcfdc1dc545fe381764795ed502a3fa0a48b87a in poky. > > I would suggest the following: > - keep the packages split > - add the new file in qcom/vpu for each package > - keep the venus.mbn path (which is now a symlink) I did a simpler thing. I think it's easier and matches the intended usage. $ dpkg-deb -c tmp-rpb-glibc/deploy/ipk/all/linux-firmware-qcom-vpu_*ipk drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/ drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/lib/ drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/lib/firmware/ drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/lib/firmware/qcom/ drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu/ drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu-1.0/ lrwxrwxrwx root/root 0 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu-1.0/venus.mbn -> ../vpu/vpu20_p4.mbn drwxr-xr-x root/root 0 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu-2.0/ lrwxrwxrwx root/root 0 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu-2.0/venus.mbn -> ../vpu/vpu20_p1.mbn -rw-r--r-- root/root 2031620 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu/vpu20_p1.mbn -rw-r--r-- root/root 1974884 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu/vpu20_p4.mbn -rw-r--r-- root/root 2306664 2024-08-09 16:02 ./usr/lib/firmware/qcom/vpu/vpu30_p4.mbn > Basically matching what I did for qcom-{qcm2290,qrb4210}-wifi? > > Cheers, > Quentin -- With best wishes Dmitry
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#203841): https://lists.openembedded.org/g/openembedded-core/message/203841 Mute This Topic: https://lists.openembedded.org/mt/108120531/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
