Hi Quentin, On Mon, May 27, 2024 at 05:20:53PM +0200, Quentin Schulz wrote: > Hi Marcus,
[...] > > > --- /dev/null > > +++ b/meta/lib/oe/bootfiles.py > > @@ -0,0 +1,56 @@ > > +# > > +# SPDX-License-Identifier: MIT > > +# > > +# Copyright (C) 2024 Marcus Folkesson > > +# Author: Marcus Folkesson <[email protected]> > > +# > > +# Utility functions handling boot files > > + > > +# Look into deploy_dir and search for boot_files. > > +# Returns a list with files to copy. > > +# > > It returns a list of tuples with (original filepath relative to deploy_dir, > desired filepath renaming) if I read the code properly, I think this is > really important information. Agree. I will add that to the comment. [...] > > from glob import glob > > You should be able to remove this import as it was only used in the code > that is now moved to the lib. True, I will remove the import. > > Otherwise looks good to me, so > > Reviewed-by: Quentin Schulz <[email protected]> > > Thanks, > Quentin Best regards, Marcus Folkesson
signature.asc
Description: PGP signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#199954): https://lists.openembedded.org/g/openembedded-core/message/199954 Mute This Topic: https://lists.openembedded.org/mt/106295831/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
