On Mon, 2012-04-02 at 07:37 -0400, Robert P. J. Day wrote:
> pretty sure i mentioned this once before but this just looks weird:
>
> $ grep -r "_append +=" *
> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append +=
> "file://use-includedir.patch \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append +=
> "${bindir}/rpcgen ${libdir}/*_nonshared.a \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append +=
> "${libdir}/*.a ${base_libdir}/*.a"
> meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I
> ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> $
>
> should those be just simple assignments?
Probably most of them should lose the _append and just use +=. I doubt
many/any of them are actually relying on the delayed semantics of
_append.
If they do require the delayed appending then yes, they should be
straight assignments with _append. All except the last example would
need a space adding on the right hand side though, in that case.
p.
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
